fix(checks): Not must not invert unevaluable failures - #2658
Closed
davidberenstein1957 wants to merge 3 commits into
Closed
fix(checks): Not must not invert unevaluable failures#2658davidberenstein1957 wants to merge 3 commits into
davidberenstein1957 wants to merge 3 commits into
Conversation
Structural miss cases (missing key, type mismatch, unsupported comparison) now set CheckResult.evaluable=False. Not passes those through unchanged so Not(Equals(missing_key)) stays fail instead of silently becoming pass (#2637).
Keep main's updated Checks/Scan quickstart examples; preserve the evaluable=False / Not passthrough changes from the feature branch. Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
2 tasks
Member
|
I would not add a new
|
|
Superseded by a different approach: structural unevaluable outcomes now return |
4 tasks
kevinmessiaen
added a commit
that referenced
this pull request
Aug 4, 2026
…-green) (#2693) fix(checks): treat structural unevaluable outcomes as ERROR Missing keys, type mismatches for configured modes, unsupported comparisons, and similar preconditions now return CheckResult.error instead of failure so Not cannot invert them into a silent pass (#2637). Assertion-false paths stay FAIL. Supersedes the evaluable field approach on #2658. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckResult.evaluable(defaultTrue). Structural “could not evaluate” failures from built-ins setevaluable=False.Notpasses unevaluable results through without inverting them, so a missing key ormatch=type mismatch no longer becomes a green suite (Not() turns a check that could not be evaluated into a pass #2637).FAILfor those cases — additive field only, no FAIL→ERROR migration.Test plan
uv run pytest libs/giskard-checks/tests/builtin/test_composition.py::TestNot(10 passed)make test-unit PACKAGE=giskard-checks(760 passed, 4 skipped)ruff check/ruff format --checkon changed Python sourcesreportInvalidTypeFormon comparison fields; CI still runs it)Closes #2637