Skip to content

fix(checks): descendants JSONPath always returns a list - #2644

Merged
kevinmessiaen merged 6 commits into
mainfrom
fix/jsonpath-descendants-list-lint
Aug 5, 2026
Merged

fix(checks): descendants JSONPath always returns a list#2644
kevinmessiaen merged 6 commits into
mainfrom
fix/jsonpath-descendants-list-lint

Conversation

@davidberenstein1957

Copy link
Copy Markdown
Member

Summary

Fixes #2633.
Supersedes #2634.

Test plan

  • make test-unit PACKAGE=giskard-checks → 761 passed, 4 skipped
  • CI lint + unit tests on this PR
  • Confirm Equals(key="trace..ctx", match="any") is stable for one vs many matches

davidberenstein1957 and others added 2 commits July 29, 2026 16:29
Unblocks check-format on PRs; same drift as CI style: auto-format.
Treat Descendants as a list-expression so resolve() does not fall back
to the match-count heuristic and return a bare scalar for a single hit.

Fixes #2633.
Supersedes #2634.

Co-authored-by: Qalipso <quadwailt@gmail.com>
Resolve README.md conflicts in favor of main (PR README edits were
ruff formatting only; functional fix is in extraction.py).

Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
davidberenstein1957 added a commit that referenced this pull request Aug 3, 2026
The reportInvalidTypeForm ignore is flagged as unnecessary after
chore(pyright): flag and remove unused ignore comments (#2690) merged
from main, which blocked the lint CI job on PR #2644.
davidberenstein1957 and others added 3 commits August 3, 2026 11:58
The reportInvalidTypeForm ignore is flagged as unnecessary after
chore(pyright): flag and remove unused ignore comments (#2690) merged
from main, which blocked the lint CI job on PR #2644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

JSONPath descendants (..) resolves to a scalar or a list depending on the data

3 participants