fix(checks): descendants JSONPath always returns a list - #2644
Merged
Conversation
Unblocks check-format on PRs; same drift as CI style: auto-format.
Resolve README.md conflicts in favor of main (PR README edits were ruff formatting only; functional fix is in extraction.py). Co-authored-by: Kevin Messiaen <kevinmessiaen@users.noreply.github.com>
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Descendants(..) as a list-expression soresolve()always returns a list (not a bare scalar when there is exactly one match).check-formatbecause README code blocks need the current ruff formatter and fork PRs cannot receive the auto-format push.reportInvalidTypeFormignore forMISSING(same pattern asrunner.py) so pre-commit basedpyright passes.Fixes #2633.
Supersedes #2634.
Test plan
make test-unit PACKAGE=giskard-checks→ 761 passed, 4 skippedEquals(key="trace..ctx", match="any")is stable for one vs many matches