Implement Block 110 solver-backed Sketch dragging#43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Block 110 of Interactive Sketcher MVP-8.
SketchPointId__gui.drag.pointer,__gui.drag.center, andzz.gui.drag.targetoutside published/committed topologyPartDocumentEsc, lost pointer capture, window deactivation, no-move handle click, and failed solveDrag sketch handleGuiDocumentSessiontransaction after source topology and constraint-system freshness checksQWidgetActionvisibility so Finish Sketch remains fully hidden after workspace exit[gui][sketch-drag]and[integration][sketch-live-solve]proofVerification on Ubuntu 24.04 with Qt 6 and OCCT:
build/dev-guitree built successfully, including app, Core tests, Geometry tests, and GUI tests[gui][sketch-drag]: 138 assertions in 5 test cases passed[integration][sketch-live-solve]: 111 assertions in 4 test cases passedBlock 106 shell enters edits repeats and finishes a contextual Sketchproof passed three consecutive isolated runs, 48 assertions eachctest --test-dir build/dev-gui --output-on-failure: 891/891 tests passedmainbefore merge