[Enhancement]Debounce SetPublisher requests #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public Interface🚀 No changes affecting the public interface. |
Generated by 🚫 Danger |
SDK Size
|
Public Interface🚀 No changes affecting the public interface. |
Public Interface🚀 No changes affecting the public interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-742/[video]debounce-setpublisher-requests
🎯 Goal
By debouncing the SetPublisher requests to reduce the load on the backend.
🛠 Implementation
I tried setting the debounce interval to the screen refresh rate but it wasn't sufficient. Setting the interval to 250 milliseconds it allows us to join a call with audio and video enabled and only fire a single SetPublisher request
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)