Skip to content

[Feature] Add support for showing current poll comment on alert #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

sheep-q
Copy link
Contributor

@sheep-q sheep-q commented Jul 22, 2025

🔗 Issue Links

N/A

🎯 Goal

Display the current poll comment in the alert (if available), and configure the background color for PollCommentsView.

📝 Summary

  • Display the current poll comment in the alert.
  • Configure the background color for PollCommentsView.

🛠 Implementation

  • Update newCommentText if the current user added a comment previously.
  • Configure ColorPalette.background as the PollCommentsView background color.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
Simulator Screenshot - 15 pro 17 5 - 2025-07-22 at 15 24 29 Simulator Screenshot - 15 pro 17 5 - 2025-07-22 at 15 24 27

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@sheep-q sheep-q requested a review from a team as a code owner July 22, 2025 08:29
@sheep-q sheep-q changed the title [Feature] show current poll comment on alert [Feature] Add support for showing current poll comment on alert Jul 22, 2025
@laevandus
Copy link
Contributor

Hi @sheep-q, I was running CI checks separately here. Could you please update snapshot test for PollAttachmentView_Tests.test_pollAttachmentView_allComments (delete existing snapshot file, run the test with iPhone 16 Pro).
Path to delete before re-running: StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/PollAttachmentView_Tests/test_pollAttachmentView_allComments.default-dark.png
Since background colour changed, it is slightly different now.

@sheep-q
Copy link
Contributor Author

sheep-q commented Jul 23, 2025

Could you please update snapshot test for PollAttachmentView_Tests.test_pollAttachmentView_allComments

Hi @laevandus, I've updated the snapshot for it, pls check it out. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants