Skip to content

Conversation

KhaledKamalA
Copy link

🎯 Goal

  • Owner user not marked as owner in channel/group details screen
  • Remove channel / group options icon
  • Channels - Number of users in channel not updated after adding a new members
  • No space between search bar and screen frame
  • No space between user picture and screen frame

@KhaledKamalA KhaledKamalA requested a review from a team as a code owner October 21, 2025 09:00
@nuno-vieira
Copy link
Member

Hi @KhaledKamalA, thank you for the PR. Since this changes a lot of things, can you please fill out the whole PR template? And include screenshots and how we can manually test this.

Thank you!

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. We would like to have more context on this one, and why are you changing this.

Comment on lines +142 to +143
) as? TrailingSwipeActionsView
return view?.hasActions ?? true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this?

*/
extension ChannelCapability {
/// Ability to add more Options the channel.
public static let moreOptionsChannel: Self = "moreOptions-channel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you see this capability? I can't find it here: https://getstream.io/chat/docs/ios-swift/channel_capabilities/

onDismiss: @escaping () -> Void,
onError: @escaping (Error) -> Void
) -> ParticipantAction {
) -> ParticipantAction? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change of the SDK, so we can't change this at the moment. Can you find an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants