-
Notifications
You must be signed in to change notification settings - Fork 111
Enhance UI elements #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Enhance UI elements #1022
Conversation
-Fix space between search bar and screen frame -Fix space between user picture and screen frame
…ed-after' into develop
Hi @KhaledKamalA, thank you for the PR. Since this changes a lot of things, can you please fill out the whole PR template? And include screenshots and how we can manually test this. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. We would like to have more context on this one, and why are you changing this.
) as? TrailingSwipeActionsView | ||
return view?.hasActions ?? true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing this?
*/ | ||
extension ChannelCapability { | ||
/// Ability to add more Options the channel. | ||
public static let moreOptionsChannel: Self = "moreOptions-channel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you see this capability? I can't find it here: https://getstream.io/chat/docs/ios-swift/channel_capabilities/
onDismiss: @escaping () -> Void, | ||
onError: @escaping (Error) -> Void | ||
) -> ParticipantAction { | ||
) -> ParticipantAction? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change of the SDK, so we can't change this at the moment. Can you find an alternative?
🎯 Goal