fix: reset message composer state partially when poll message is sent #2703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 463 463
Lines 9183 9187 +4
Branches 2094 2095 +1
==========================================
+ Hits 7507 7510 +3
- Misses 1571 1572 +1
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +332 B (+0.03%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
May 13, 2025
# Conflicts: # src/components/MessageInput/hooks/useSubmitHandler.ts
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
## [13.0.1](v13.0.0...v13.0.1) (2025-05-15) ### Bug Fixes * clear composer state optimistically with snapshot restoration upon sending a message ([#2710](#2710)) ([b6e91a2](b6e91a2)) * inject error into PollComposer state if native numeric field validation fails ([#2702](#2702)) ([8bca9f0](8bca9f0)) * prevent sorting poll options in place ([#2699](#2699)) ([88590f1](88590f1)) * reflect maxRows in TextareaComposer and allow to add lines ([#2709](#2709)) ([990e15c](990e15c)) * reset message composer state partially when poll message is sent ([#2703](#2703)) ([5708807](5708807))
|
🎉 This PR is included in version 13.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
When sending a poll message (contains only poll id) the composer id has to be created anew (for the next msg) and the poll composer state has to be reset. The rest of the states should be kept as they can be used for the next message.
This should be moved to the LLC in the future, once
MessageComposer.sendMessage()exists.