feat: add message history #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaljam
requested review from
yaziine,
totalimmersion,
akupila and
JimmyPettersson85
as code owners
message_history.go
Outdated
| } | ||
|
|
||
| func (c *Client) QueryMessageHistory(ctx context.Context, request QueryMessageHistoryRequest) (*QueryMessageHistoryResponse, error) { | ||
| if request.Filter == nil { |
There was a problem hiding this comment.
nitpick: check for len() == 0 here instead of nil since map[string]any{} can be non-nil with 0 items
There was a problem hiding this comment.
right, confused map with slices.
JimmyPettersson85
previously approved these changes
May 23, 2024
shaljam
force-pushed
the
pbe-3774-message-history
branch
from
577d2f0 to
90b106d
Compare
JimmyPettersson85
approved these changes
May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
Add ability to query message history.