-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Github pull request labeler #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughTwo new configuration files establish automated PR labeling: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/labeler.yml (3)
146-152: Consider scoping asset patterns to avoid over-labeling.The asset glob patterns (
*.png,*.jpg,*.gif,*.mp4,*.wav,*.mp3, etc.) will match media files at any directory level in the repository. This may incorrectly label test fixtures, example assets, or build artifacts as "assets."Consider narrowing these patterns to a specific directory:
- assets: - - assets/** - - '*.png' - - '*.jpg' - - '*.jpeg' - - '*.gif' - - '*.mp4' - - '*.wav' - - '*.mp3' + assets: + - assets/** + - assets/*.png + - assets/*.jpg + - assets/*.jpeg + - assets/*.gif + - assets/*.mp4 + - assets/*.wav + - assets/*.mp3Alternatively, keep root-level media files if they're expected at the repo root.
96-110: Clarify intent of overlapping config and CI patterns.Both the
configlabel (lines 96–101) andcilabel (lines 108–110) include*.ymland*.yamlpatterns. This means workflow files and other YAML files will receive both labels.Is this intended—i.e., are YAML files expected to be tagged with both labels? If so, consider documenting this behavior. If not, consider refining the patterns:
- Option 1: Remove
*.ymland*.yamlfromconfigto avoid overlap.- Option 2: Add an exclusion rule to
configto exclude files matchingcipatterns.This is a minor clarity/hygiene issue since GitHub's labeler applies multiple labels correctly; just ensure the behavior matches your intent.
83-86: Minor: Redundant test pattern.The pattern
**/tests/**on line 84 subsumes the patterntests/**on line 83. Consider removing line 83 for clarity:tests: - - tests/** - '**/tests/**' - '**/test_*.py' - '**/*_test.py'Both patterns work correctly; this is just a minor efficiency and clarity improvement.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/labeler.yml(1 hunks).github/workflows/labeler.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unit / Ruff & mypy
- GitHub Check: unit / Test "not integration"
🔇 Additional comments (2)
.github/workflows/labeler.yml (1)
1-12: Workflow setup looks good.Clean and correct configuration:
pull_request_targetis the appropriate trigger for PR labeling (safer thanpull_requestfor workflows with write permissions), and permissions are scoped appropriately. The labeler action will automatically discover.github/labeler.yml..github/labeler.yml (1)
1-165: Comprehensive label structure.The labeler configuration is well-organized and covers a broad range of project components: core framework, 13 specific plugins, examples, tests, documentation, configuration, CI/CD, infrastructure layers, CLI tools, dependencies, assets, legal documents, and project metadata. The use of inclusion and exclusion patterns (e.g.,
!plugins/**/tests/**,!agents-core/**/__pycache__/**) is thoughtful and will keep PR labels focused on meaningful code changes. The per-plugin labels will be valuable for maintainability and team workflows.
Adds a labeler CI workflow to categorize pull requests.
Summary by CodeRabbit