25528 #298
Draft
25528 #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "swagger-ui-react": "^5.11.3" | ||
| "react-router-hash-link": "^2.4.3", | ||
| "react-socks": "^2.2.0", | ||
| "react-table": "^7.8.0", |
There was a problem hiding this comment.
We probably shouldn't have both "react-table" and "@tanstack/react-table". If posible we should deprecate the older and update the components that use it
| @@ -25,16 +25,30 @@ | |||
| "@popperjs/core": "^2.11.6", | |||
| "@tanstack/react-query": "^5.14.1", | |||
| "@tanstack/react-table": "^8.7.9", | |||
| "axios": "^1.3.2", | |||
| "axios": "^1.8.3", | |||
There was a problem hiding this comment.
This seems like a lot of additional dependencies. We be good to double check that all of these are really needed
| @@ -0,0 +1,137 @@ | |||
| import { ReactComponent as Archive } from './archive.svg' | |||
There was a problem hiding this comment.
We should scale this list down to only the icons needed by the toolbar and delete the unused svg files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the notes in the ticket:
Move the "Manage Columns" feature into the new DataTableToolbar component.
Ensure that drag-and-drop functionality is working, and include the PDC-style badges to indicate hidden and reordered columns.
A new ticket is created to replace react-dnd to dnd-kit