lint(package): upgraded @poolofdeath20/eslint-config

GervinFung · Sep 21, 2024 · db8ef3f · db8ef3f
1 parent 904f313
commit db8ef3f
Show file tree

Hide file tree

Showing 5 changed files with 345 additions and 377 deletions.
diff --git a/apps/web/Makefile b/apps/web/Makefile
@@ -110,7 +110,7 @@ format-write:
 
 ## lint
 lint:
-	pnpm eslint --ignore-path .gitignore --ext .mjs,.tsx,.ts --color && pnpm knip
+	pnpm eslint . --color && pnpm knip
 
 ## typecheck
 typecheck:

diff --git a/apps/web/eslint.config.mjs b/apps/web/eslint.config.mjs
@@ -1,65 +1,40 @@
 import process from 'process';
-import eslint from '@eslint/js';
+
 import { includeIgnoreFile } from '@eslint/compat';
+import eslint from '@eslint/js';
+import { node, next } from '@poolofdeath20/eslint-config';
 import tseslint from 'typescript-eslint';
 
+const allowedFor = ['SyntaxHighlighter', 'Image'];
+
 export default tseslint.config(
+	// @ts-expect-error: type mismatch between eslint and eslint-compat
 	includeIgnoreFile(`${process.cwd()}/.gitignore`),
 	eslint.configs.recommended,
 	...tseslint.configs.recommendedTypeChecked,
 	...tseslint.configs.strict,
 	...tseslint.configs.stylistic,
+	node,
 	{
-		files: ['script/mongo-setup/document.js'],
-		rules: {
-			'no-undef': 'off',
-		},
-		extends: [tseslint.configs.disableTypeChecked],
-	},
-	{
-		settings: {
-			react: {
-				version: 'detect',
-			},
-		},
-		linterOptions: {
-			reportUnusedDisableDirectives: 'error',
-		},
-		languageOptions: {
-			parserOptions: {
-				projectService: true,
-				tsconfigRootDir: import.meta.dirname,
-			},
-		},
+		...next,
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		rules: {
-			'@typescript-eslint/array-type': [
-				'error',
-				{
-					default: 'generic',
-				},
-			],
-			'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
-			'@typescript-eslint/no-unused-vars': [
-				'error',
-				{
-					args: 'all',
-					argsIgnorePattern: '^_',
-					caughtErrors: 'all',
-					caughtErrorsIgnorePattern: '^ignore',
-					destructuredArrayIgnorePattern: '^_',
-					ignoreRestSiblings: true,
-				},
-			],
-			'react/prop-types': 'off',
-			'react/jsx-uses-react': 'off',
-			'react/react-in-jsx-scope': 'off',
-			'no-mixed-spaces-and-tabs': ['error', 'smart-tabs'],
-			'arrow-body-style': ['error', 'always'],
-			'no-restricted-syntax': [
+			...next.rules,
+			'react/jsx-child-element-spacing': 'off',
+			'react/forbid-component-props': [
 				'error',
 				{
-					selector: 'TSEnumDeclaration',
-					message: "Don't declare enums",
+					forbid: [
+						{
+							propName: 'style',
+							allowedFor,
+							message: `Props "style" is forbidden for all components except ${allowedFor
+								.map((component) => {
+									return `"${component}"`;
+								})
+								.join(', ')}`,
+						},
+					],
 				},
 			],
 		},

diff --git a/apps/web/knip.ts b/apps/web/knip.ts
@@ -8,14 +8,14 @@ const config: KnipConfig = {
 		'src/**/*.ts',
 		'script/**/*.ts',
 	],
-	ignore: ['next-sitemap.config.js', 'public/**.js'],
-	ignoreBinaries: ['make', 'puppeteer/install.mjs'],
+	ignore: ['next-sitemap.config.js'],
+	ignoreBinaries: ['make'],
 	ignoreDependencies: [
-		'vite-node',
+		'eslint',
 		'next-sitemap',
 		'prettier',
-		'eslint',
 		'supabase',
+		'vite-node',
 	],
 };
 

diff --git a/apps/web/package.json b/apps/web/package.json
@@ -46,7 +46,7 @@
 		"@ducanh2912/next-pwa": "^10.2.8",
 		"@eslint/compat": "^1.1.1",
 		"@eslint/js": "^9.8.0",
-		"@poolofdeath20/eslint-config": "^0.3.4",
+		"@poolofdeath20/eslint-config": "^0.4.0",
 		"@poolofdeath20/tsconfig": "^0.1.1",
 		"@types/cors": "^2.8.17",
 		"@types/eslint__js": "^8.42.3",
@@ -58,7 +58,7 @@
 		"@typescript-eslint/eslint-plugin": "^7.18.0",
 		"@typescript-eslint/parser": "^7.18.0",
 		"ci-info": "^4.0.0",
-		"eslint": "^9.8.0",
+		"eslint": "^9.9.1",
 		"eslint-plugin-jsx-a11y": "^6.9.0",
 		"eslint-plugin-react": "^7.35.0",
 		"gen-env-type-def": "^0.0.4",