Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt for topology and geometrychecker plugin name changes in 3.28 #122

Open
wants to merge 5 commits into
base: dev-QGIS3
Choose a base branch
from

Conversation

frankbroniewski
Copy link
Contributor

The names for the plugins Topology checker and Geometrychecker have changed in QGIS 3.28 and the current version of the plugin is not able to find these by iterating over the vector menu. This PR adds the new names to the conditional check so that the actions can be used in the plugin.

I have tested this with QGIS 3.28 on Windows, earlier versions of QGIS should continue to work as before. I also tested it with the latest version of QGIS 3.34 (Nightly). I cannot test the changes on Mac unfortunately ...

@frankbroniewski
Copy link
Contributor Author

On QGIS 3.34 the plugin fails to start with the folllowing error:

2024-07-01T14:07:25     WARNING    Traceback (most recent call last):
              File "C:\Users/broniewski/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\PagLuxembourg\project.py", line 76, in open
              self._setupTopologicalSettings()
              File "C:\Users/broniewski/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\PagLuxembourg\project.py", line 253, in _setupTopologicalSettings
              QgsProject.instance().writeEntry('Digitizing', '/DefaultSnapTolerance', 10.0)
             TypeError: QgsProject.writeEntry(): arguments did not match any overloaded call:
              overload 1: argument 3 has unexpected type 'float'
              overload 2: argument 3 has unexpected type 'float'
              overload 3: argument 3 has unexpected type 'float'

which is fixed with the latest commit in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant