trigger auto tag on PR edit and merge #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-635_automate_tag_on_merge/ |
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
mki-c2c
changed the title
…_tag_on_merge_test_merge test trigger on merge
tkohr
approved these changes
Aug 9, 2024
.github/workflows/ci_bundle.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Could also be v4 as above, I guess.
| ### Automatic tag in CI | ||
|
|
||
| On merge of a PR on main branch the CI will create an automatic tag of type | ||
| <branch_name>\_CI\_<short_commit> |
There was a problem hiding this comment.
So the difference between manual "dev" tags created on a branch and tags automatically created on main is the "TAG" vs "CI" part if I see right. Just wondering if other terms would be more explicit to identify the difference without becoming too long. WDYT of "DEV_TAG" instead of "TAG"?
There was a problem hiding this comment.
just _DEV_ instead of _TAG_ ??
README.md
Outdated
|
|
||
| #### cleaning usused tags | ||
|
|
||
| there is not any CI automation yet. However, the naming conventio that dev tags shall start with the branch name, makes cleaning them much easier. |
There was a problem hiding this comment.
Suggested change
| there is not any CI automation yet. However, the naming conventio that dev tags shall start with the branch name, makes cleaning them much easier. | |
| There is not any CI automation yet. However, the naming convention that dev tags shall start with the branch name, makes cleaning them much easier. |
* output all test variables * fix workflow * fix workflow * pretty print objects * fix echo quoting * fix quotes * test tags * clean workflow * create auto tag on branch pushes instead of PR * debug bash * test mutli cmd run * do use env variable * cleanup * verbose output * fix echo * fix bash * another bash check * unecho * echo variants * more echos * checkout * check git version * deepen fetch to find parents * cleanup * set correct tag names and job activation conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue
https://jira.camptocamp.com/browse/GSLUX-635
Description
automatic tag generation on PRs
the workflow was tested with the sub PR below:
#132
this created correctly the release https://github.com/Geoportail-Luxembourg/luxembourg-geoportail/releases/tag/GSLUX-635_automate_tag_on_merge_test_merge_CI_8e1839f
the manual workflow (npm run tag) was tested with this release:
https://github.com/Geoportail-Luxembourg/luxembourg-geoportail/releases/tag/GSLUX-635_automate_tag_on_merge_TAG_c1576cd
checks:
Screenshots
(only if the final render is different)