Skip to content

fix(install): programmatically clean gga clone dir to avoid collision #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decode2 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

fix(install): programmatically clean gga clone dir to avoid collision #961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/installcmd/resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ func resolveGGAInstall(profile system.PlatformProfile) (CommandSequence, error)
}, nil
case "apt", "pacman", "dnf":
const tmpDir = "/tmp/gentleman-guardian-angel"
_ = os.RemoveAll(tmpDir)
return CommandSequence{
{"rm", "-rf", tmpDir},
{"git", "clone", "https://github.com/Gentleman-Programming/gentleman-guardian-angel.git", tmpDir},
Expand All @@ -274,6 +275,7 @@ func resolveGGAInstall(profile system.PlatformProfile) (CommandSequence, error)
// PowerShell is used for cleanup to avoid cmd.exe quoting issues with
// embedded double quotes in the "if exist ... rmdir" approach.
cloneDst := filepath.Join(os.TempDir(), "gentleman-guardian-angel")
_ = os.RemoveAll(cloneDst)
bash := gitBashPath()
return CommandSequence{
{"powershell", "-NoProfile", "-Command", fmt.Sprintf("Remove-Item -Recurse -Force -ErrorAction SilentlyContinue '%s'; exit 0", cloneDst)},
Expand Down
Loading