fix(engram): prevent double MCP registration in Antigravity and support Linuxbrew path - #1580
Closed
eezzekl wants to merge 4 commits into
Closed
fix(engram): prevent double MCP registration in Antigravity and support Linuxbrew path#1580eezzekl wants to merge 4 commits into
eezzekl wants to merge 4 commits into
Conversation
…rt Linuxbrew path
📝 WalkthroughWalkthroughAntigravity Engram registration now uses the standard MCP arguments, avoids writing a plugin-level ChangesEngram registration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 20, 2026
Contributor
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #797
🏷️ PR Type
What kind of change does this PR introduce?
type:bug— Bug fix (non-breaking change that fixes an issue)type:feature— New feature (non-breaking change that adds functionality)type:docs— Documentation onlytype:refactor— Code refactoring (no functional changes)type:chore— Build, CI, or tooling changestype:breaking-change— Breaking change (fix or feature that changes existing behavior)📝 Summary
mcp_config.jsonin the Antigravity plugin directory; Engram MCP is now registered exactly once, in the global CLI config./home/linuxbrew/.linuxbrew/bin/engram) as a stable path so auto-injection works on Linux installs via Linuxbrew.--tools=agentwhen launching the Engram MCP server for Antigravity, instead of stripping it for that agent.📂 Changes
internal/components/engram/inject.go--tools=agent; removed duplicate plugin-scopemcp_config.jsonwrite; added Linuxbrew path toisStableHomebrewEngramPathinternal/components/engram/inject_test.go--tools=agentand to expect no plugin-scopemcp_config.jsonfile🧪 Test Plan
go test ./...)go run ./internal/gofmtcheck)cd e2e && ./docker-test.sh)CI will run the full suite; local
gotoolchain wasn't available in this environment to run it beforehand.✅ Contributor Checklist
status:approvedsize:exceptionwith rationale documentedtype:*label to this PRgo test ./...)go run ./internal/gofmtcheck)cd e2e && ./docker-test.sh)Co-Authored-Bytrailers💬 Notes for Reviewers
Local
gowas not runnable in this environment (permission denied on thegobinary), so unit/format/E2E checks weren't executed locally before opening this PR — relying on CI to confirm. Branch was rebased onto latestorigin/mainbefore opening (no conflicts ininternal/components/engram/inject.godespite other commits touching that file in between).Summary by CodeRabbit