Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c75b07133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| find_dependency(Boost REQUIRED COMPONENTS context coroutine) | ||
| find_dependency(Snappy CONFIG REQUIRED) | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/rlpTargets.cmake") |
There was a problem hiding this comment.
The package config template still includes rlpTargets.cmake, but the install step now exports evmrelayTargets.cmake (CMakeLists.txt installs FILE evmrelayTargets.cmake). After installation, find_package(evmrelay) will reference a targets file that is not installed, breaking downstream consumers.
Useful? React with 👍 / 👎.
CMakeLists.txt
Outdated
| configure_package_config_file(${CMAKE_CURRENT_SOURCE_DIR}/cmake/config.cmake.in | ||
| "${CMAKE_CURRENT_BINARY_DIR}/rlpConfig.cmake" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/evmrelayConfig.cmake" | ||
| INSTALL_DESTINATION ${rlp_CONFIG_DESTINATION_DIR} |
There was a problem hiding this comment.
The destination variable was renamed to evmrelay_CONFIG_DESTINATION_DIR, but configure_package_config_file() still uses ${rlp_CONFIG_DESTINATION_DIR}. Because that variable is undefined here, argument parsing treats NO_SET_AND_CHECK_MACRO as the install destination value, which generates incorrect package metadata and an invalid install-destination hint in the config file.
Useful? React with 👍 / 👎.
CMakeLists.txt
Outdated
| find_package(GTest CONFIG REQUIRED) | ||
| endif() | ||
|
|
||
| set(CMAKE_INSTALL_INCLUDEDIR "${CMAKE_INSTALL_INCLUDEDIR}/rlp/") |
There was a problem hiding this comment.
This change prepends CMAKE_INSTALL_INCLUDEDIR with rlp/, so headers are installed under <prefix>/include/rlp/... (and src/rlp adds another /rlp segment), but the library still advertises INSTALL_INTERFACE:include. Consumers linking the installed target will search <prefix>/include and fail to resolve public includes that now live under the nested include/rlp tree.
Useful? React with 👍 / 👎.
…ixed for this project at least, SuperGenius is next
1 participant
Updated to new library and repo name