Develop

.github/workflows/benchmarks.yml

@@ -1,13 +1,6 @@
 name: Performance Benchmarks
 
 on:
-  push:
-    branches: [ "main", "dev_peer_discovery" ]
-  pull_request:
-    branches: [ "main", "dev_peer_discovery" ]
-  schedule:
-    # Run weekly on Sunday at 5 AM UTC
-    - cron: '0 5 * * 0'
   workflow_dispatch:
 
 jobs:

.github/workflows/cmake-multi-platform.yml

@@ -2,16 +2,6 @@ name: Release Build CI
 
 on:
   push:
-    branches:
-      - develop
-      - main
-    paths-ignore:
-      - ".github/**"
-      - "Readme.md"
-  pull_request:
-    branches:
-      - develop
-      - main
     paths-ignore:
       - ".github/**"
       - "Readme.md"
@@ -21,9 +11,113 @@ on:
         description: "Release tag"
         required: false
         type: string
+      android:
+        description: "Build Android targets"
+        required: false
+        type: boolean
+        default: true
+      ios:
+        description: "Build iOS targets"
+        required: false
+        type: boolean
+        default: true
+      osx:
+        description: "Build OSX targets"
+        required: false
+        type: boolean
+        default: true
+      linux:
+        description: "Build Linux targets"
+        required: false
+        type: boolean
+        default: true
+      windows:
+        description: "Build Windows targets"
+        required: false
+        type: boolean
+        default: true
 
 jobs:
+  prepare-matrix:
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.set-matrix.outputs.matrix }}
+    steps:
+      - name: Select build matrix
+        id: set-matrix
+        shell: bash
+        env:
+          SELECT_ANDROID: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.android == 'true' }}
+          SELECT_IOS: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.ios == 'true' }}
+          SELECT_OSX: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.osx == 'true' }}
+          SELECT_LINUX: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.linux == 'true' }}
+          SELECT_WINDOWS: ${{ github.event_name != 'workflow_dispatch' || github.event.inputs.windows == 'true' }}
+        run: |
+          python3 - <<'PY' >> "$GITHUB_OUTPUT"
+          import json
+          import os
+
+          entries = [
+              {
+                  "target": "Linux",
+                  "runner": ["self-hosted", "X64", "Linux"],
+                  "abi": "x86_64",
+                  "build-type": "Release",
+                  "container": "ghcr.io/geniusventures/debian-bullseye:latest",
+              },
+              {
+                  "target": "Linux",
+                  "runner": "sg-arm-linux",
+                  "abi": "aarch64",
+                  "build-type": "Release",
+                  "container": "ghcr.io/geniusventures/debian-bullseye:latest",
+              },
+              {
+                  "target": "Windows",
+                  "runner": ["self-hosted", "Windows"],
+                  "abi": "",
+                  "build-type": "Release",
+              },
+              {
+                  "target": "OSX",
+                  "runner": "gv-OSX-Large",
+                  "abi": "",
+                  "build-type": "Release",
+              },
+              {
+                  "target": "Android",
+                  "runner": "sg-ubuntu-linux",
+                  "abi": "arm64-v8a",
+                  "build-type": "Release",
+              },
+              {
+                  "target": "Android",
+                  "runner": ["self-hosted", "X64", "Linux"],
+                  "abi": "armeabi-v7a",
+                  "build-type": "Release",
+              },
+              {
+                  "target": "iOS",
+                  "runner": "macos-latest",
+                  "abi": "",
+                  "build-type": "Release",
+              },
+          ]
+
+          selected = {
+              "android": os.environ["SELECT_ANDROID"].lower() == "true",
+              "ios": os.environ["SELECT_IOS"].lower() == "true",
+              "osx": os.environ["SELECT_OSX"].lower() == "true",
+              "linux": os.environ["SELECT_LINUX"].lower() == "true",
+              "windows": os.environ["SELECT_WINDOWS"].lower() == "true",
+          }
+
+          include = [entry for entry in entries if selected[entry["target"].lower()]]
+          print(f"matrix={json.dumps({'include': include}, separators=(',', ':'))}")
+          PY
+
   build:
+    needs: prepare-matrix
     env:
       GRPC_BUILD_ENABLE_CCACHE: "ON"
       GH_TOKEN: ${{ secrets.GNUS_TOKEN_1 }}
@@ -36,40 +130,7 @@ jobs:
         password: ${{ secrets.GNUS_TOKEN_1 }}
     strategy:
       fail-fast: false
-      matrix:
-        target: [ Android, iOS, OSX, Linux, Windows ]
-        build-type: [ Release ]
-        abi: [ "" ]
-        include:
-          - target: Linux
-            runner: sg-ubuntu-linux
-            abi: "x86_64"
-            build-type: "Release"
-            container: ghcr.io/geniusventures/debian-bullseye:latest
-          - target: Linux
-            runner: sg-arm-linux
-            abi: "aarch64"
-            build-type: "Release"
-            container: ghcr.io/geniusventures/debian-bullseye:latest
-          - target: Windows
-            runner: [ self-hosted, Windows ]
-          - target: OSX
-            runner: gv-OSX-Large
-          - target: Android
-            runner: sg-ubuntu-linux
-            abi: arm64-v8a
-            build-type: "Release"
-          - target: Android
-            runner: sg-ubuntu-linux
-            abi: armeabi-v7a
-            build-type: "Release"
-          - target: iOS
-            runner: macos-latest
-        exclude:
-          - target: Android
-            abi: ""
-          - target: Linux
-            abi: ""
+      matrix: ${{ fromJSON(needs.prepare-matrix.outputs.matrix) }}
     steps:
       - name: Configure Git Bash on Windows
         if: ${{ runner.environment == 'self-hosted' && matrix.target == 'Windows' }}
@@ -362,7 +423,12 @@ jobs:
       - name: Build rlp
         working-directory: ${{ github.workspace }}/rlp/${{ env.BUILD_DIRECTORY }}
         run: cmake --build . --config ${{ matrix.build-type }} -j
-
+
+      - name: Test rlp (non-mobile)
+        if: ${{ matrix.target != 'Android' && matrix.target != 'iOS' }}
+        working-directory: ${{ github.workspace }}/rlp/${{ env.BUILD_DIRECTORY }}
+        run: ctest . -C ${{ matrix.build-type }} --output-on-failure -V
+
       - name: Install rlp
         working-directory: ${{ github.workspace }}/rlp/${{ env.BUILD_DIRECTORY }}
         run: cmake --install . --config ${{ matrix.build-type }}

.github/workflows/fuzz.yml

@@ -1,13 +1,6 @@
 name: Fuzz Testing
 
 on:
-  push:
-    branches: [ "main", "dev_peer_discovery" ]
-  pull_request:
-    branches: [ "main", "dev_peer_discovery" ]
-  schedule:
-    # Run nightly fuzzing for longer duration at 4 AM UTC
-    - cron: '0 4 * * *'
   workflow_dispatch:
     inputs:
       duration:

.github/workflows/sanitizers.yml

@@ -1,13 +1,6 @@
 name: Memory Safety - Sanitizers
 
 on:
-  push:
-    branches: [ "main", "dev_peer_discovery" ]
-  pull_request:
-    branches: [ "main", "dev_peer_discovery" ]
-  schedule:
-    # Run nightly at 2 AM UTC
-    - cron: '0 2 * * *'
   workflow_dispatch:
 
 jobs:

.github/workflows/valgrind.yml

@@ -1,13 +1,6 @@
 name: Memory Safety - Valgrind
 
 on:
-  push:
-    branches: [ "main", "dev_peer_discovery" ]
-  pull_request:
-    branches: [ "main", "dev_peer_discovery" ]
-  schedule:
-    # Run nightly at 3 AM UTC
-    - cron: '0 3 * * *'
   workflow_dispatch:
 
 jobs:

.gitignore

@@ -15,3 +15,48 @@ build/
 # Test log files
 /tmp/eth_watch_*.log
 examples/*.log
+
+# User-specific stuff
+.idea/**/workspace.xml
+.idea/**/tasks.xml
+.idea/**/usage.statistics.xml
+.idea/**/dictionaries
+.idea/**/shelf
+
+# github copilot
+.idea/**/copilot*
+# AWS User-specific
+.idea/**/aws.xml
+
+# Generated files
+.idea/**/contentModel.xml
+
+# Sensitive or high-churn files
+.idea/**/dataSources/
+.idea/**/dataSources.ids
+.idea/**/dataSources.local.xml
+.idea/**/sqlDataSources.xml
+.idea/**/dynamic.xml
+.idea/**/uiDesigner.xml
+.idea/**/dbnavigator.xml
+
+# CMake
+cmake-build-*/
+
+# File-based project format
+*.iws
+
+# IntelliJ
+out/
+
+# Android studio 3.1+ serialized cache file
+.idea/caches/build_file_checksums.ser
+
+### CLion+iml Patch ###
+# Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-249601023
+
+*.iml
+modules.xml
+.idea/misc.xml
+*.ipr
+

AgentDocs/AGENT_MISTAKES.md

@@ -142,7 +142,19 @@ Live network testing cannot distinguish between "our crypto is wrong" and "the p
 - When adding a new declaration, always look at the surrounding declarations in the same header and match their Doxygen style exactly.
 - Never silently omit `@param` or `@return` for non-trivial declarations.
 
-### M018 — Using `std::cout` / `std::cerr` for debug output instead of spdlog
+### M019 — Using C++20 `boost::asio::awaitable` in code that must build on C++17 targets
+**What happened**: Async network functions were written using C++20 native coroutines (`boost::asio::awaitable<T>`, `co_await`, `co_return`, `boost::asio::this_coro::executor`). This fails to compile on Debian 11 Bullseye with older Clang/GCC that only support C++17 (e.g. Clang 11/12 shipped with Bullseye).  
+**Root cause**: Wrote the first convenient async pattern without checking the minimum compiler/standard requirement for all build targets.  
+**Rule**: The project must compile under C++17 (Debian 11 Bullseye is a supported target). **Never use C++20 coroutine keywords** (`co_await`, `co_return`, `co_yield`) or `boost::asio::awaitable<T>` / `boost::asio::this_coro::executor`. Use the C++17-compatible **Boost stackful coroutine** API instead:
+- Replace `boost::asio::awaitable<T>` return types with `T` (returning directly).
+- Add `boost::asio::yield_context yield` as the last parameter to every async function.
+- Replace `co_await op(asio::use_awaitable)` → `op(yield)`.
+- Replace `co_return value` → `return value`.
+- Replace `boost::asio::co_spawn(exec, coro, token)` → `boost::asio::spawn(exec, [](yield_context yield){...})`.
+- Replace `co_await boost::asio::this_coro::executor` → `yield.get_executor()`.
+- Link `Boost::coroutine` and `Boost::context` in CMake target_link_libraries.
+
+
 **What happened**: When a debug print was needed, `std::cerr` was inserted directly into source code, requiring an `#include <iostream>` and a build cycle to observe behaviour.  
 **Root cause**: Reaching for the obvious C++ I/O stream instead of using the project's established logging system.  
 **Rule**: **Never use `std::cout` or `std::cerr` for debug output.** Use the project spdlog system exclusively:
@@ -154,3 +166,11 @@ Live network testing cannot distinguish between "our crypto is wrong" and "the p
 3. The global spdlog level is already controlled by the `--log-level` CLI flag in `eth_watch` (and similar entry points). Setting `--log-level debug` will show all `DEBUG` output with zero code changes.
 4. `std::cout` is only acceptable for **user-facing program output** (e.g., final results printed to the terminal by design). It is never acceptable for diagnostic or debug output.
 
+---
+
+## SUBMODULE MANAGEMENT
+
+### M015 — Incorrectly reverting the `build` submodule pointer
+**What happened**: When merging `enr_records` into `copilot/discv5-implementation`, the `build` submodule pointer was updated from `bc5302b` to `f09f0cb` (the latest `main` of cmaketemplate). This was mistakenly reverted to `bc5302b`, which is the *older* commit and lacks Android library support. `f09f0cb` is the correct commit — it adds the `android::log`/`android::android` interface targets and thirdparty directory updates.  
+**Rule**: When the `build` submodule pointer changes during a merge, verify whether the new commit is from the latest `main` of cmaketemplate. If it is, keep it (or update to it). The correct workflow to update the submodule is: go into `build/`, run `git pull && git checkout main`, then `cd ..` and `git add build`.
+