feat(channels): HTTP JSON adapter and ScriptedChannel reference (#564)#640
Merged
matedev01 merged 3 commits intoJul 6, 2026
Merged
Conversation
7 tasks
…ePod#564) Extract incoming_turn_from_chat_json into channel::http and add ScriptedChannel as a public reference Channel impl. HTTP chat routes now import the shared adapter; behavior unchanged.
a13ff73 to
1371e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #564 (port voice, HTTP, and Telegram onto the
Channeltrait).Supersedes the closed #609 (speaker-tagging work landed via #611/#631); this branch is repurposed for the HTTP
Channelreference adapter.Summary
First HTTP reference-adapter slice for the
Channelboundary:channel::http::incoming_turn_from_chat_json— shared JSON →IncomingTurnparser (speaker + session fields)channel::scripted::ScriptedChannel— public in-processChannelfor tests/harnesses/api/chatthrough the shared adapter (behavior unchanged; logic moved out ofserver.rs)Voice and Telegram porting remain follow-ups in #564.
Real Behavior Proof
Tested profile / hardware:
laptop(x86_64 Linux dev host)What I ran
What I observed
channel::unit tests pass (HTTP JSON parsing +ScriptedChannelrecv/send + registry).incoming_turn_from_chat_jsonfromchannel::http— no duplicate parser inserver.rs.Test plan
channel::http::tests::*— speaker string/object parsing, session key derivationchannel::scripted::tests::recv_send_round_trip_records_outboundchannel::tests::scripted_channel_recv_send_round_tripcargo clippy -p genie-core --all-targets -- -D warnings