fix(provider): require optional provider model id (#620)#621
Draft
Daedalus-Icarus wants to merge 1 commit into
Draft
fix(provider): require optional provider model id (#620)#621Daedalus-Icarus wants to merge 1 commit into
Daedalus-Icarus wants to merge 1 commit into
Conversation
Contributor
|
Reviewed — correct fix for #620 (model="default" hardcoding), clean plumbing. Please finalize: unmark draft, tick the proof section, and rebase (BEHIND). Ready to merge once green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #620.
Parameterize the optional OpenAI-compatible provider path with an explicit model id instead of letting it fall back to the generic
"default"placeholder.Changes
[optional_ai_provider].modelto config and require it when the optional provider path is enabledLlmClient::from_config()into the OpenAI-compatible backendReal Behavior Proof
Tested profile / hardware (check all that apply):
jetsonraspberry_piportable_sbclaptopmacWhat I ran
What I observed
[optional_ai_provider].modelis empty"default"Test plan
[optional_ai_provider]with a local mock OpenAI-compatible endpoint and a realmodelvalue.model./v1/chat/completionsrequest and verify the configured model id is present in the JSON body.Notes for reviewers
This is a narrow follow-up to the merged provider-selection work from #595: provider selection was config-driven, but provider model selection was still hardcoded in the generic request profile.