Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for using Stream Deck+ Encoder to change Sonos volume #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

indomitableMan
Copy link

Added new AdjustVolume action to support using a StreamDeck+ Encoder to adjust volume and mute Sonos system.

Added new AdjustVolume action to support using a StreamDeck+ Encoder to adjust volume and mute Sonos system.
@gruen-e
Copy link

gruen-e commented Jun 20, 2023

$ ./DistributionTool -b -i src/com.genericmale.sonos.sdPlugin -o release                                            « ±feat---Add-StreamDeck-Plus-Support ✓
         using printf
         Validating and exporting the plugin src/com.genericmale.sonos.sdPlugin
         Error: The action 'com.genericmale.sonos.adjustvolume' has an "Icon" property with the value '[email protected]' which is not an existing file on disk. Please add a valid value to the property "Icon" in the manifest.json
         Error: The plugin is invalid

Did you create an Icon and didn't commit it?

(Also, THANK YOU FOR THIS)

@indomitableMan
Copy link
Author

The icon is one of the existing material design icons that this plug-in already uses. However as noted elsewhere this code is not 100% functional due to a library conflict. I need to perform further work on this code to get it working properly.

@jer78
Copy link

jer78 commented Nov 29, 2023

@indomitableMan Let me know if you're still working on this and need a tester. I just upgraded to the Stream Deck + today so I can now help beta test.

@indomitableMan
Copy link
Author

I am not currently doing any further work on this plug-in. Due to the library conflict and a couple of architectural issues, I think I will start on a new Sonos plug-in exclusively for the Streamdeck+ after the new year.

@jer78
Copy link

jer78 commented Nov 29, 2023

Ok sounds good. Let me know if I can help sometime in the new year with testing.

@joshferrell
Copy link

@GenericMale Is there anything left to do on this plugin where it would be able to get merged?

@indomitableMan otherwise, would you be willing to send your built elgato file? I don't have a windows machine to bundle things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants