Add game filtering by publisher and category#17
Open
GeekTrainer wants to merge 3 commits into
Open
Conversation
- Add publisher_id and category_id query parameters to /api/games - Add /api/publishers endpoint for filter dropdown - Add /api/categories endpoint for filter dropdown - Add unit tests for filtering functionality
- Create GameFilters.svelte with publisher/category dropdowns - Integrate filters into GameList.svelte - Add clear filters functionality - Include data-testid attributes for testability
- Test filter controls visibility and accessibility - Test filtering by publisher and category - Test clear filters functionality - Test combined filter scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A user reported that they were unable to filter games by publisher and category. After investigation, this functionality did not exist. This PR implements game filtering to allow users to filter the games list by publisher and/or category.
Changes
/api/gamesendpoint/api/publishersand/api/categoriesendpoints for filter dropdownsGameFilters.sveltecomponent with publisher/category dropdownsGameList.svelteBackend API Changes
The
/api/gamesendpoint now accepts optional query parameters:New endpoints for filter options:
GET /api/publishers- Returns all publishersGET /api/categories- Returns all categoriesCode snippet
Frontend Changes
New
GameFilters.sveltecomponent with:Testing
Test coverage includes: