IIB2019018 #4
Open
IIB2019018 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope all the content has reached. This was my first PR.
Member
|
@Niftyy please take a look at this. |
thesmallstar
requested changes
Dec 10, 2019
Member
thesmallstar
left a comment
thesmallstar
left a comment
There was a problem hiding this comment.
Please take a look at your directory structure.
Author
|
@thesmallstar sorry, i didn't get you |
tushparte
requested changes
Dec 10, 2019
Collaborator
tushparte
left a comment
tushparte
left a comment
There was a problem hiding this comment.
Fix directory structure, take a look at previous submissions. You have to add only one folder inside Task - 1 which contains everything.
Author
|
@thesmallstar @Niftyy sir i just committed the previous task with some changes. i hope the changes expected have been made. |
tushparte
requested changes
Dec 12, 2019
Collaborator
tushparte
left a comment
tushparte
left a comment
There was a problem hiding this comment.
The directory name inside the "Task - 1" directory must be your enrollment number, in your case which is "photos" I believe, please change it.
Author
|
Sir i had uploaded another one. Named by my roll no.
…On Fri, 13 Dec 2019, 00:38 Tushar Singh, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The directory name inside the "Task - 1" directory must be your enrollment
number, in your case which is "photos" I believe, please change it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AN67OCNJ24CSO5Q2ECO4QDLQYKDZ5A5CNFSM4JYZXYU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPA2NFQ#pullrequestreview-331458198>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN67OCLHPDSNJEF5DNEB7R3QYKDZ5ANCNFSM4JYZXYUQ>
.
|
Author
|
@thesmallstar @Niftyy sir i have made some changes. please merge my pull request too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope all the content has reached. This was my first PR.