Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: Migrate to Typescript. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilmaske-2001
Copy link
Contributor

@nikhilmaske-2001 nikhilmaske-2001 commented Sep 28, 2021

Fixes #20.
Renamed all files with extension .tsx.

Testing plan: Everything works fine after this changes.

@boxdox
Copy link

boxdox commented Sep 28, 2021

Hook should end in .ts since they are not returning any jsx. Also, types are needed first, not just changing the file extension.

@nikhilmaske-2001
Copy link
Contributor Author

nikhilmaske-2001 commented Sep 28, 2021

@boxdox Almost all functions are returning the jsx element, can you please check it again?
Yes, I am working on adding types.

@boxdox
Copy link

boxdox commented Sep 28, 2021

i am talking about src/index.js, that's a plain hook, no jsx returned. also, i am curious what does this project offer, when there are alternatives available?

@Gautam-Arora24
Copy link
Owner

@boxdox Currently the library is bare-bone, and I have few ideas that can be implemented in the library -->

  • Measure dimensions of lazy-loaded elements.
  • Add testing support to the library.

If you have any ideas that can make this library stand out from others, feel free to post them in this issue. Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Typescript.
3 participants