Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 39.30% 40.32% +1.02%
==========================================
Files 30 30
Lines 1743 1758 +15
==========================================
+ Hits 685 709 +24
+ Misses 1058 1049 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OwenPriceSkelly
approved these changes
Dec 9, 2025
Member
OwenPriceSkelly
left a comment
There was a problem hiding this comment.
LGTM (with a small possible gotcha, nothing blocking)
| ) | ||
| retry_count = 0 | ||
| except requests.HTTPError as e: | ||
| if ( |
Member
There was a problem hiding this comment.
nit: I'm 95% sure that we want extra parens around ((e.response.status_code == 502 or e.response.status_code == 504) and retry_count <= 3)
Collaborator
Author
There was a problem hiding this comment.
I'll get that in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps us work around the backend memory leak problem when polling on a long-ish running Modal function.
After 30 seconds we'll wait for 5 seconds when polling. And if we see a 502 or 504, that usually means the server is restarting. We can just wait for a little and try again in that case.
📚 Documentation preview 📚: https://garden-ai--650.org.readthedocs.build/en/650/