Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Text-to-speech not working #186

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix: Text-to-speech not working #186

merged 2 commits into from
Jan 30, 2025

Conversation

bricefriha
Copy link
Collaborator

Text-to-speech didn't work due to the input binding context of the button.
It's now fixed

closes #183

@bricefriha bricefriha merged commit 4e7ae8f into develop Jan 30, 2025
3 checks passed
@bricefriha bricefriha deleted the fix/#183_tts branch January 30, 2025 11:02
bricefriha added a commit that referenced this pull request Jan 30, 2025
* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button
bricefriha added a commit that referenced this pull request Feb 2, 2025
* v1.6.2 (#187)

* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button

* Fetcher - Error handlelin | make sure all the call are using `HandleHttpException()`
bricefriha added a commit that referenced this pull request Feb 3, 2025
* v1.6.2 (#187)

* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button

* pre-build - android | specify project folder specifically

* ss
bricefriha added a commit that referenced this pull request Feb 3, 2025
* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button

* Error handling - Make sure to handle all API call exceptions (#188)

* v1.6.2 (#187)

* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button

* Fetcher - Error handlelin | make sure all the call are using `HandleHttpException()`

* CI/CD | fix app constants (#189)

* v1.6.2 (#187)

* workflow - dev| bump version

* fix: Article page HTML rendering (#184)

* Article detail - UI | Introduce a CSS file to set up the layout

* Article page | disable webview for content as it's way too buggy

* cleaup - article view | remove redandent stuff

* Style - article | add brighter colours for links

* Workflow - android dev | unset change review

* Correct README.md

* Fix: Text-to-speech not working (#186)

* Android - TTS | manage permissions

* Article - TTS | mentioning Binding context to the TTS button

* pre-build - android | specify project folder specifically

* ss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant