fix(pwa): remove broken navigateFallback breaking SSR page refresh - #1071
Merged
sanaderi merged 1 commit intoJul 22, 2026
Merged
Conversation
globPatterns is empty (no assets precached), so navigateFallback: '/' made the generated service worker throw workbox-precaching's "non-precached-url" error on every navigation once the SW controlled the page. That intercepted page refreshes and broke subsequent API calls in production. Confirmed via console error on gamatrain.com and by reproducing only outside incognito (where the SW persists). Also removes an unused $toast destructure in the admin school contributions page that was blocking the pre-commit lint hook.
|
@sanaderi is attempting to deploy a commit to the GamaEdtech Team on Vercel. A member of the Team first needs to authorize it. |
sanaderi
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uncaught (in promise) non-precached-url: non-precached-url :: [{"url":"/"}]from the generated Workbox service worker, and subsequent client-side API calls fail to fire correctly.nuxt.config.js'spwa.workbox.navigateFallback: '/'tells the SW to intercept every navigation and serve a precached copy of/, butglobPatterns: []means nothing — including/— is ever precached. Once a service worker from a prior visit controls the page, every refresh hits this broken fallback instead of loading normally.navigateFallbackentry. Precaching was already effectively disabled (globPatterns: []), so this doesn't reduce any working offline functionality — it just removes the dangling reference that throws.$toastdestructured but unused inapp/pages/admin/schools/contributions/index.vue) that was blocking the pre-commit hook.Test plan
npx eslintpasses on both changed files (verified locally)non-precached-urlconsole error on refresh in a normal (non-incognito) browser session/paper/[id]/[slug])