Add 1D Beer-Lambert photochemistry solver with Cantera integration - #10
Open
GalacticBobster with Copilot wants to merge 4 commits into
Open
Add 1D Beer-Lambert photochemistry solver with Cantera integration#10GalacticBobster with Copilot wants to merge 4 commits into
GalacticBobster with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: GalacticBobster <85122891+GalacticBobster@users.noreply.github.com>
Co-authored-by: GalacticBobster <85122891+GalacticBobster@users.noreply.github.com>
Co-authored-by: GalacticBobster <85122891+GalacticBobster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix instability in matrix solver for photochemistry
Add 1D Beer-Lambert photochemistry solver with Cantera integration
Nov 23, 2025
Owner
|
Extend it by writing an example to solve one dimensional photochemical equilibrium with parameterized eddy and binary diffusion and boundary conditions. |
GalacticBobster
marked this pull request as ready for review
November 24, 2025 05:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a one-dimensional photochemistry solver using Beer-Lambert law for actinic flux attenuation, leveraging Cantera's chemical kinetics framework.
Implementation
New directory:
examples/BeerLambert1D/(308 LOC solver + config + docs)Core algorithm:
Features:
ThermoPhase/Kinetics/SolutionintegrationBuild:
TASK=BeerLambertbeer_lambert_1d.yamlFollows existing C3M patterns from
src/actinic_flux.cppandtests/1DPP.cpp.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.