Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors for GT ore refactor PR #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RecursivePineapple
Copy link

Changes:

  • Remove some mixins that targetted GT and replaced them with forge events (I kept the scanner mixins because I didn't need to change those and they're quite complex)
  • Removed the old chunk TE loading code and replaced it with a system that partially loads chunks
  • Removed all references to ore meta & the material provider system in lieu of the new IOreMaterial system
  • Included second-most common ore in ChunkAnalysis matchesSingleVein filter
  • Misc cleanup

Testing done:

  • Spawn in new world & prospect with prospector to make sure veins are detected on world generate
  • Travel a few dozen chunks in a direction and prospect again to make sure new veins are detected properly
  • Right click on ore to make sure the vein is prospected properly
  • Stress test /vp_recache and profile it to make sure there aren't any trivial optimizations left
  • Test ross & everglades prospecting (everglades works properly now and ross was already fixed)

depends on: GTNewHorizons/GT5-Unofficial#3662

@RecursivePineapple RecursivePineapple added the bug Something isn't working label Feb 23, 2025
@RecursivePineapple RecursivePineapple requested review from Lyfts and a team February 23, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant