Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PBR specular & normal textures getting ignored #874

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Conversation

RecursivePineapple
Copy link
Contributor

  • Stack was being overfilled by MemoryStack
  • Added tons of logging for ignored important exceptions
  • Added missing interface on mixin (should it be moved to gtnhlib?)
  • Move PBR debug to angelica config (was a system property)

- Stack was being overfilled by MemoryStack
- Added tons of logging for ignored important exceptions
- Added missing interface on mixin (should it be moved to gtnhlib?)
@RecursivePineapple RecursivePineapple added the bug Something isn't working label Feb 18, 2025
@RecursivePineapple
Copy link
Contributor Author

I swapped the MemoryStack to a heap alloc because I kept getting stack overflow errors from the stack alloc. The exceptions were ignored due to all of the empty catches, so I added some logging there to prevent this from happening again.
The method I changed is only used to download GPU textures onto the CPU so that the PBR atlas can be dumped to a file. It's only ran when PBR dumping is enabled, and even then it's only ran once.

There was a ClassCastException being ignored too, so I added the interface to the accessor mixin which was missing it.

@mitchej123 mitchej123 enabled auto-merge (squash) February 18, 2025 18:33
@mitchej123 mitchej123 merged commit 81d03ea into master Feb 18, 2025
1 check passed
@mitchej123 mitchej123 deleted the fix-pbr branch February 18, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants