Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ANGELICA_VERSION into a string, so it doesn't fail parsing on commit hash #873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarkShadow44
Copy link
Contributor

No description provided.

@Cleptomania
Copy link
Member

Hmm, is this treated as a string in Iris? My worry is that this is intended to function similarly to the IRIS_VERSION define, and shaders might do numerical comparisons on that?

@DarkShadow44
Copy link
Contributor Author

The version is currently 1.0.0-beta33, wouldn't that break it already? Not sure how it's supposed to be used, but having a macro that calculates "1.0.0 - beta33" doesn't seem very useful.

@Cleptomania
Copy link
Member

Iris does it like, giving one digit for the major version, and then 2 digit for minor/patch releases, encoded into a single number, like so:

1.8.0 -> 10800
1.6.17 -> 10617
1.7.3 -> 10703

I'm not really sure exactly how shaders utilize this value, and there's probably not really any shaders utilizing Angelica's define currently, but we should probably try to stay in line with Iris for this I think. That being said, I'm not sure how to fit that with our current versioning

@kurrycat2004
Copy link
Collaborator

i mean iris also only extracts the semver from the actual mod version using this regex: "(?<major>\\d+)\\.(?<minor>\\d+)\\.*(?<bugfix>\\d*)(.*)", so they dont care about anything other than the semver version, so maybe doing something like that would be an idea (also this regex is weird, it would match 1.0............0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants