feat: display files as expandable subrows in File Directory table - #83
Conversation
✅ Deploy Preview for juno-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Greptile SummaryThis PR restructures the File Buckets table into a File Directory table with TanStack Table v8 expandable subrows, adding folder/file icons, status chips (NOT UPLOADED / UPLOADED / EXTERNAL), and a copy-to-clipboard action per file row. The changes are well-scoped across three files: Issues to address:
Confidence Score: 4/5Safe to merge after addressing the missing filterFromLeafRows option — the core feature works but a stated filtering requirement is unmet. One P1 logic defect exists: the filter box cannot match file subrow names because filterFromLeafRows: true is not set, directly contradicting the PR's own requirement. The remaining findings are P2 (clipboard error handling, hardcoded colors). No data loss or security risk is introduced. src/components/baseTable.tsx — missing filterFromLeafRows: true when expandable is enabled. Important Files Changed
|
Add opt-in expanding support to BaseTable and restructure the file bucket table to show files as nested subrows with status chips, icons, and copy-to-clipboard actions.
Populate the table with 4 mock buckets and 15 files across all three statuses (NOT UPLOADED, UPLOADED, EXTERNAL) so the UI can be demoed while backend integration is pending. Falls back to real API data when available.
018dd3c to
c2c5ac4
Compare
Add opt-in expanding support to BaseTable and restructure the file bucket table to show files as nested subrows with status chips, icons, and copy-to-clipboard actions.
Summary
Closes #81
Restructures the File Bucket table into a File Directory table with expandable subrows for files, opt-in expanding support in
BaseTable, status chips, icons, and copy-to-clipboard.Checklist from issue
Changes
baseTable.tsx— Added opt-inexpandableprop withgetExpandedRowModel(),ExpandedState, and subrow background stylingcolumns.tsx— NewFileDirectoryRowtype with expand toggle, folder/file icons, status badge chips (red/green/yellow), and copy-to-clipboard actionfileBucketTable.tsx— Data transform buildssubRowswith mock statuses, heading renamed, delete handler differentiates bucket vs file rowsTest plan
bits_of_good_sprint4_demo.mp4