Available user types filtered based on user role

[shaply]

Although we block it on the backend, the UI for an Admin when they navigate to a per-project user page has the illusion of being able to set SUPERADMIN permissions:

Reproduction Steps

1. Sign into an ADMIN type (if you don't have one, create a new user using the superadmin credentials)
2. Navigate to a per-project page (e.g. http://localhost:3000/projects/0/users) and create a new user (this will be of type USER). This works as expected.
3. Attempt to edit this new user and set the User Type. ADMIN and SUPERADMIN should not be options available for this. Currently, this just throws an ambiguous error if you try to do so anyways.

Fix

Remove user types depending on the user type

Added filtering of user types selectable based on user session when editing a user.

[netlify]

✅ Deploy Preview for juno-dashboard ready!

Name	Link
🔨 Latest commit	c22bc62
🔍 Latest deploy log	https://app.netlify.com/projects/juno-dashboard/deploys/691aba0d16fe310008786747
😎 Deploy Preview	https://deploy-preview-62--juno-dashboard.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[greptile-apps]

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Greptile Summary

• Filters available user types in edit form dropdown based on current user's role (SUPERADMIN can assign all types, ADMIN can only assign USER)
• Uses useMemo hook to compute available user types and integrates with SessionProvider for current user context

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The implementation correctly filters user types based on role permissions and aligns with backend security, though there's a minor UX consideration when ADMINs view higher-privileged users
• No files require special attention

Important Files Changed

Filename	Overview
src/components/forms/EditUserForm.tsx	Filtered user type dropdown based on current user's role - SUPERADMIN sees all types, ADMIN sees only USER

Sequence Diagram

sequenceDiagram
    participant "User" as User
    participant "EditUserForm" as Form
    participant "SessionProvider" as Session
    participant "Backend API" as API
    
    User->>Form: "Open edit user dialog"
    Form->>Session: "Get current user session"
    Session-->>Form: "Return user type (SUPERADMIN/ADMIN/USER)"
    Form->>Form: "Filter available user types based on current user role"
    Form->>User: "Display form with filtered user type dropdown"
    User->>Form: "Select user type and submit"
    Form->>API: "Call setUserTypeAction with selected type"
    API-->>Form: "Return success/error"
    Form->>User: "Show toast notification"

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format}

[netlify]

❌ Deploy Preview for juno-dashboard failed. Why did it fail? →

Name	Link
🔨 Latest commit	90fbb7b
🔍 Latest deploy log	https://app.netlify.com/projects/juno-dashboard/deploys/6997e8ba77da0d00089a4e6e

[netlify]

✅ Deploy Preview for juno-dashboard ready!

Name	Link
🔨 Latest commit	cf3c706
🔍 Latest deploy log	https://app.netlify.com/projects/juno-dashboard/deploys/69cf1361d10769000820e07b
😎 Deploy Preview	https://deploy-preview-62--juno-dashboard.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[llam36]

LGTM!