Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue template updates #824

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

brian-ruf
Copy link
Contributor

@brian-ruf brian-ruf commented Oct 25, 2024

Committer Notes

This PR adds one new issue template and modifies an existing issue template.
The new issue template is specifically for constraint work.
The action-item template was modified to remove obsolete choices and to direct the submitter to the automate.fedramp.gov repo for issues related to documentation.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@brian-ruf brian-ruf marked this pull request as ready for review October 25, 2024 19:52
@brian-ruf brian-ruf requested a review from a team as a code owner October 25, 2024 19:52
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, minor feedback and some questions about how we want to approach some of the implied consequences. Otherwise, very good stuff and I hope to merge soon.

@aj-stein-gsa aj-stein-gsa changed the base branch from feature/626-issue-template to master October 25, 2024 20:39
@aj-stein-gsa aj-stein-gsa requested a review from a team October 25, 2024 20:39
@aj-stein-gsa
Copy link
Contributor

Sorry for the delayed review, @brian-ruf. Also that feature branch isn't necessary and I wasn't fast enough to get rid of it. We can just target master for this given the other issues I need to report. I will take care of that bug report soonish. 😄

@brian-ruf brian-ruf linked an issue Oct 25, 2024 that may be closed by this pull request
@aj-stein-gsa aj-stein-gsa linked an issue Oct 25, 2024 that may be closed by this pull request
9 tasks
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @brian-ruf. I'll add my approval once the comments @aj-stein-gsa sent are resolved

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I held this up for longer in the day I had planned, I like it from Friday and you addressed all the feedback I was concerned with. The other feedback items are not critical.

(Thanks to @Rene2mt to remind me how tardy I am this late in the afternoon.)

@aj-stein-gsa aj-stein-gsa merged commit 136f3c6 into GSA:master Oct 28, 2024
7 checks passed
Gabeblis pushed a commit to Gabeblis/fedramp-automation that referenced this pull request Dec 9, 2024
* issue template updates

* fixed attributes

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/3-action-item.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

* Update .github/ISSUE_TEMPLATE/4-constraint-work.yaml

Co-authored-by: A.J. Stein <[email protected]>

---------

Co-authored-by: A.J. Stein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Issue Template for Constraint Work
3 participants