add nginx-basicauth.conf #1654
Merged
add nginx-basicauth.conf #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuhuXia
force-pushed
the
add-local-basic-auth
branch
from
c21944b to
0ef2053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding basic auth on staging:catalog-next-web instance.
Basic auth was added to staging:catalog-web instance via cloudfront. Not sure why. Adding basic auth to nginx is more convenient, can be turn on/off with one variable, and works for both scenario regardless the app is behind cloudfront or not. catalog-web is behind cloudfront, catalog-next-web is not yet behind cloudfront.