block malicious traffic with 429 code #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a custom 429 error page and configures NGINX to return it for requests flagged as malicious by AWS WAF.
- Introduce
429.htmltemplate for “Unusual Activity Detected” responses - Include
nginx-malicious429.confto detecthttp_x_amzn_waf_detectionand return 429 - Update
nginx.confto load the new malicious-traffic rules
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| proxy/public/429.html | New static error page for HTTP 429 responses |
| proxy/nginx.conf | Added include for nginx-malicious429.conf |
| proxy/nginx-malicious429.conf | New rules to block WAF-detected malicious requests (429) |
Comments suppressed due to low confidence (2)
proxy/public/429.html:6
- Add a
<meta charset="utf-8">tag near the top of<head>to explicitly declare the page’s character encoding and avoid potential rendering issues.
<meta name="viewport" content="width=device-width, initial-scale=1.0">
proxy/nginx-malicious429.conf:1
- There are no automated tests covering this new malicious-traffic rule. Consider adding an integration test to verify that requests with the
http_x_amzn_waf_detection: maliciousheader receive a 429 response and render the custom error page.
# block malicious requests detected by AWS WAF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works together with AWS WAF rules and Advanced Shield. If a request is marked by AWS with header
http_x_amzn_waf_detection, we respond with 429 code.