update datagovtheme and change config for user session #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the session configuration to integrate the session fix code from ckanext-datagovtheme and implements a 15-minute idle timeout while upgrading the datagovtheme dependency.
- Integrates new session settings using SESSION_PERMANENT and PERMANENT_SESSION_LIFETIME
- Upgrades ckanext-datagovtheme from version 0.3.7 to 0.3.8
- Adds commented .env entries for potential cloud.gov session behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ckan/setup/ckan.ini | Removes legacy beaker session options and introduces new session settings |
| ckan/requirements.txt | Updates the datagovtheme dependency version |
| .env | Adds commented-out session configuration options for cloud.gov behavior |
Comments suppressed due to low confidence (1)
ckan/setup/ckan.ini:36
- Removal of legacy beaker session options could confuse readers; consider adding a comment to explain how the new SESSION_PERMANENT and PERMANENT_SESSION_LIFETIME settings integrate with the existing session configuration.
-beaker.session.type=ext:database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GSA/data.gov#5253