fix: include BOOLEAN_OPERATION in SVG container collapse#314
Merged
Conversation
Boolean operations (UNION, SUBTRACT, INTERSECT, EXCLUDE) always produce vector output but were missing from the SVG rollup logic, causing them to block parent containers from collapsing to IMAGE-SVG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BOOLEAN_OPERATIONtoSVG_ELIGIBLE_TYPESso boolean ops are recognized as SVG-eligible childrenBOOLEAN_OPERATIONto the parent collapse check incollapseSvgContainersso boolean op containers can collapse toIMAGE-SVGwhen all their children are SVG-eligibleTest plan
BOOLEAN_OPERATIONwith vector children collapses toIMAGE-SVGFRAMEcontaining aBOOLEAN_OPERATIONcollapses transitively (bottom-up)