Skip to content

Set explicit JSON body size limit for /mcp #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheodorNEngoy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set explicit JSON body size limit for /mcp #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ export async function startServer(): Promise<void> {
export async function startHttpServer(host: string, port: number, mcpServer: McpServer): Promise<void> {
const app = express();

// Parse JSON requests for the Streamable HTTP endpoint only, will break SSE endpoint
app.use("/mcp", express.json());
// Parse JSON requests for the Streamable HTTP endpoint only (this will break SSE endpoints),
// and enforce an explicit body size limit to reduce DoS risk.
app.use("/mcp", express.json({ limit: "1mb" }));

// Modern Streamable HTTP endpoint
app.post("/mcp", async (req, res) => {
Expand Down