Open
Conversation
This patch adds a check to avoid using select() on sockets that are not selectable (i.e. socket descriptor >= FD_SETSIZE). On platforms where select() is used for non-blocking connect timeouts, attempting to use FD_SET on a large socket descriptor would trigger undefined behavior and could lead to a crash. Now, if the socket is non-selectable, the connection attempt will fail gracefully with a log message instead of causing an abort. This improves stability on systems with high file descriptor allocation or large ulimit settings. - DeckerSU/KomodoOcean#113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a check to avoid using select() on sockets that are not
selectable (i.e. socket descriptor >= FD_SETSIZE). On platforms where
select() is used for non-blocking connect timeouts, attempting to use
FD_SET on a large socket descriptor would trigger undefined behavior
and could lead to a crash.
Now, if the socket is non-selectable, the connection attempt will fail
gracefully with a log message instead of causing an abort. This improves
stability on systems with high file descriptor allocation or large
ulimit settings.
p.s. Also it includes #682 .