Conversation
|
Visit the preview URL for this PR (updated for commit eaf3ce3): https://walletrc--pull-3429-merge-kxe65ykx.web.app (expires Wed, 25 Mar 2026 16:07:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
* chore: add generated deprecation notices for legacy rpc errors * feat: add polish foundation for trading and withdrawals * chore: roll sdk foundation pointer
* Port full Flutter WASM support * chore(gitignore): ignore local AI skill bundles * chore(sdk): roll submodule for wasm-safe interop cleanup * fix(web): address WASM review feedback
…#3444) * fix(app): resolve open findings and adopt sdk manager APIs * chore(app): roll sdk submodule for pr review fixes * chore(docs): remove local review artifacts from tracked docs * chore(app): roll sdk submodule to merged dev commit
* fix(web): isolate cache adapters and update JS interop * fix(app): backfill wallet metadata display * chore: update CI Flutter version * chore: update Flutter packages * chore: roll Flutter constraints * chore: update Docker Flutter version
* feat(legal): render terms of service from markdown asset * fix(legal): prevent tos popup freeze on open * chore: add pubspec assets * fix(disclaimer): improve ToS markdown rendering and dialog behavior * feat(legal): load legal docs from GitHub at runtime * feat(legal): add kyc policy to settings
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaf3ce30a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void _syncWalletTypeWithSeedCompatibility() { | ||
| if (_isHdMode && !_isHdCompatibleWithCurrentSeed) { | ||
| _isHdMode = false; | ||
| _allowCustomSeed = false; |
There was a problem hiding this comment.
_syncWalletTypeWithSeedCompatibility() now flips _isHdMode to false as soon as _isHdCompatibleWithCurrentSeed returns false. Because _isHdCompatibleWithCurrentSeed only returns true once 12+ words form a fully valid BIP39 phrase, a user entering a 24-word mnemonic (or even the last word of a 12-word mnemonic) is silently switched to Iguana mode mid-entry and will import the wallet with the wrong derivation unless they notice and switch it back before submitting.
Useful? React with 👍 / 👎.
| // Fall back to the legacy global key so existing users keep their last | ||
| // selection until this wallet writes its own scoped preference. | ||
| final legacyValue = await storage.read(hdWalletModePreferenceKey); | ||
| return _parseStoredPreference(legacyValue); |
There was a problem hiding this comment.
Falling back to the old global hdWalletModePreferenceKey makes every wallet without a scoped preference inherit the last mode used by any other wallet. On existing installs, that means opening an HD wallet after previously selecting legacy mode elsewhere will preselect Iguana here and WalletLogin will attempt the wrong auth mode, surfacing a spurious “incorrect password” until the user manually flips the switch back.
Useful? React with 👍 / 👎.
| bool get _isTradingMenuActive { | ||
| final currentMenu = routingState.selectedMenu; | ||
| return currentMenu == MainMenuValue.dex || | ||
| currentMenu == MainMenuValue.bridge; |
There was a problem hiding this comment.
runUpdate() now throttles foreground polling unless _isTradingMenuActive is true, but this getter only recognizes dex and bridge. The market-maker page still depends on TradingEntitiesBloc (see lib/views/market_maker_bot/market_maker_bot_page.dart), so while the user is actively on that screen their swaps/orders will now refresh on the 45-second background cadence instead of the 10-second foreground cadence.
Useful? React with 👍 / 👎.
2 participants
No description provided.