Add export endpoint #269
Merged
Add export endpoint #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we wait for this to be available in the public API? |
|
Translation still missing. |
koebi
requested changes
Sep 13, 2024
ORStools/proc/export_proc.py
Outdated
Comment on lines
116
to
117
| to_coords = self.get_location_by_id(to_id, response["nodes"]) | ||
| from_coords = self.get_location_by_id(from_id, response["nodes"]) |
There was a problem hiding this comment.
This iterates all nodes twice for every edge, taking what is in theory a linear operation and making it quadratic.
I think it makes sense to parse nodes into a dict to look up coordinates easily.
|
After testing for a bit, I think it makes sense to also export nodes into a separate layer - it's a bit too tricky from my perspective to correctly parse them from the edge layer. |
koebi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extent choosable via QgsProcessingParameterExtent.