Skip to content

Conversation

@darktorres
Copy link
Member

Summary

Replaces the previous clock delay spinbox with a custom LabeledSlider widget that displays period fraction values (-1/2 to 1/2) under slider ticks for intuitive phase delay adjustment.

Changes

  • Add LabeledSlider custom widget with period fraction label rendering
  • Replace DoubleSpinBox with QSlider in ElementEditor UI
  • Restrict slider range to -4 to 4 (representing -1/2 to 1/2 period)
  • Display labels as fractions: -1/2, -3/8, -1/4, -1/8, 0, 1/8, 1/4, 3/8, 1/2
  • Implement backward compatibility by discarding old delay data (< 4.3)
  • Fix phase delay direction: negative values advance the clock, positive values delay it
  • Update CMakeSources.cmake with new widget files
  • Fix include file ordering for code style compliance

Test plan

  • Build project successfully with cmake --preset release && cmake --build --preset release
  • Run full test suite: ctest --test-dir build
  • Verify clock slider displays period fraction labels under ticks
  • Test phase delay: negative slider values advance clock, positive values delay clock
  • Load files saved with previous versions (< 4.3) to verify backward compatibility
  • Verify slider range is restricted to -4 to +4 with no wrapping at extremes

🤖 Generated with Claude Code

darktorres and others added 2 commits November 16, 2025 15:52
… Qt 6.9.2 MSVC2022

Updates the windows-qt CMake preset to:
- Use Visual Studio 17 2022 generator instead of Ninja for proper MSVC support
- Point to Qt 6.9.2 MSVC2022 installation path
- Enables Release builds with MSVC compiler

This fixes compilation issues on Windows with MSVC-built Qt libraries.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Replaces the previous clock delay spinbox with a custom LabeledSlider widget
that displays period fraction values (-1/2 to 1/2) under slider ticks for
intuitive phase delay adjustment.

Changes:
- Add LabeledSlider custom widget with period fraction label rendering
- Replace DoubleSpinBox with QSlider in ElementEditor UI
- Restrict slider range to -4 to 4 (representing -1/2 to 1/2 period)
- Display labels as fractions: -1/2, -3/8, -1/4, -1/8, 0, 1/8, 1/4, 3/8, 1/2
- Implement backward compatibility by discarding old delay data (< 4.3)
- Fix phase delay direction: negative=advance, positive=delay
- Update CMakeSources.cmake with new widget files
- Fix include file ordering for code style compliance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@darktorres darktorres merged commit 9974e78 into master Nov 16, 2025
13 checks passed
@darktorres darktorres deleted the clock_delay branch November 16, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants