Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1069
This PR is an attempt to clean up the WW3 CMake code by preventing duplication. This update uses the
switch_strings
string and makes aW3_
-prefixed list from that.I'll keep draft until @adarmenov can test. At the moment, I can say things build, but maybe it's making garbage WW3 code since I can't run test. But the resulting CMake files have:
which seems right. (NOTE: I added the newlines in that. In Cmake land it's one looooong line)