Skip to content

refactor: Use an enum to deal with the piece of attributes and not bool #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

refactor: Use an enum to deal with the piece of attributes and not bool #195

wants to merge 23 commits into from

Conversation

@RomainBaville
Copy link
Contributor

@RomainBaville RomainBaville commented Nov 28, 2025 •
edited
Loading

This PR aims to update the way of dealing with the piece of an attribute.
Instead of using a bool with True for points attributes and False for cells attributes, the idears is to use an enum to manage more precisely the piece inforamtion of an attribute:

  • The attribute is on points (Piece.POINTS)
  • The attribute is on cells (Piece.CELLS)
  • The attribute is on both pieces (Piece.BOTH)
  • The attribute is not on a piece but on field (Piece.FIELD)
  • The attribute is not on the mesh at all (Piece.NONE)

@RomainBaville RomainBaville self-assigned this Nov 28, 2025
@RomainBaville RomainBaville added test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: refactor labels Nov 28, 2025
@RomainBaville RomainBaville marked this pull request as ready for review December 2, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paloma-martinez paloma-martinez Awaiting requested review from paloma-martinez

@jafranc jafranc Awaiting requested review from jafranc

@alexbenedicto alexbenedicto Awaiting requested review from alexbenedicto

At least 1 approving review is required to merge this pull request.

Assignees

@RomainBaville RomainBaville

Labels

flag: ready for review test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RomainBaville