Skip to content

fix c++20 implementations #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix c++20 implementations #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/shiva/functions/bases/BasisProduct.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ struct BasisProduct
// expand pack over number of dimensions
return executeSequence< numDims >( [&]< int ... PRODUCT_TERM_INDEX > () constexpr
{
return ( BASIS_TYPE::template value< BASIS_FUNCTION_INDICES >( parentCoord[PRODUCT_TERM_INDEX] ) * ... );
return ( BASIS_TYPES::template value< BASIS_FUNCTION_INDICES >( parentCoord[PRODUCT_TERM_INDEX] ) * ... );
} );
#else
return executeSequence< numDims >( [&] ( auto ... PRODUCT_TERM_INDEX ) constexpr
Expand Down
2 changes: 1 addition & 1 deletion include/shiva/functions/bases/LagrangeBasis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class LagrangeBasis : public SPACING_TYPE< REAL_TYPE, ORDER + 1 >
auto func = [&coord]< int ... b > ( auto aa ) constexpr
{
constexpr int aVal = decltype(aa)::value;
return gradientOfValueTerm< BF_INDEX, aVal >() * ( valueProductFactor< BF_INDEX, b, aVal >( coord ) * ... );
return gradientOfValueTerm< BF_INDEX, aVal >() * ( valueProductTerm< BF_INDEX, a >( coord ) * ... );
};

return ( executeSequence< numSupportPoints >( func, std::integral_constant< int, a >{} ) + ... );
Expand Down