-
Notifications
You must be signed in to change notification settings - Fork 9
Adding wrappers for device math functions and polar decomposition #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmcrook5
wants to merge
52
commits into
develop
Choose a base branch
from
feature/crook5/math
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
d52e573
initial commit, added an algorithm to fixedSizeSquareMatrixOps that c…
povolny1 6d4875e
implementation of polar decomposition complete, still need to test
povolny1 02e0e1c
Fixed cmake so that GEOSX TPLs work and also updated spack.
corbett5 63a85d1
Merge branch 'corbett/tpl-fix-spack-update' into feature/povolny1/pol…
povolny1 943b300
implemented unit test for polar decomposition
povolny1 ddcd7b4
made error message in polar decomposition GPU-compatible
povolny1 f591570
Merge branch 'develop' into feature/povolny1/polarDecomposition
povolny1 ab63869
merge from develop
povolny1 1339ea7
Added device math functions for ceil, floor, and power
82f1ce3
Merge branch 'develop' into feature/crook5/math
1e0127a
Corrected host only function inside of checkIndices preventing device…
343432d
Merge branch 'develop' into feature/crook5/math
rrsettgast bf73593
Added debugging flags to host configs
8e86706
wip: trying to fix build error on Lassen.
CusiniM c021cc5
use fold expression to do index checks
rrsettgast efc221d
revert changes to typeManipulation.
CusiniM 9275fe7
use bool return value.
CusiniM 882b587
use fold expression.
CusiniM e599472
fix function name
CusiniM 00e117d
doxygen.
CusiniM 1ccdce5
fix typo.
CusiniM 956aa7c
add other integral types.
CusiniM 8eb4727
add debug assert.
CusiniM 2fa2667
add all integral types.
CusiniM 2343b7d
add char types
CusiniM ddc611e
add decay type.
CusiniM 52c1d5e
add a static cast option
CusiniM 58fc69d
remove assert.
CusiniM d89ed76
clean up.
CusiniM ac6c0fd
remove chars.
CusiniM c2efd00
just always cast to long long.
CusiniM e60fa8f
forgotten one.
CusiniM 4194bc9
Merged cusini/fix-lassen-error
65c00ec
aoa and aoav traits
wrtobin cff7f1b
just a typo fix
wrtobin 1ada56a
Committing changes to pull from remote
2522acf
Merge branch 'feature/crook5/math' of github.com:GEOS-DEV/LvArray int…
557f07c
Merge branch 'develop' into feature/crook5/math
6a90517
Merged develop
c3fcf1f
Merge branch 'feature/povolny1/polarDecomposition' into feature/crook…
fead905
Updated branch with current versions from develop that were overriden…
00327f8
Fixed compilation error related to polarDecomposition
95aa41e
Removed wrong namespace
85136be
Fixed incorrect type
34a4ea5
Added round to math and cofactor to square tensor ops for 2x2 and 3x3…
fa06984
Updated formatting
ebf14c8
Merge branch 'feature/crook5/math' of github.com:GEOS-DEV/LvArray int…
7d4a46b
Fixed bug in unit tests for cofactors
a1f3c56
Fixed typo in unittests
bed5b66
Removed unused variable
8aebaa5
Added invert for 4x4 matrices
d452637
Added determinant and inverse operations for square 4x4 matrices
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| set( PREPROCESSOR_DEFINES UMPIRE | ||
| CHAI | ||
| CUDA | ||
| HIP | ||
| HIP | ||
| TOTALVIEW_OUTPUT | ||
| CALIPER ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| set(CONFIG_NAME "dane-clang-14-mpm" CACHE PATH "") | ||
|
|
||
| set(GEOS_TPL_DIR /usr/WS1/crook5/thirdPartyLibs/install-dane-clang-14-mpm-release CACHE PATH "") | ||
|
|
||
| include(${CMAKE_CURRENT_LIST_DIR}/llnl-cpu-clang-14.cmake) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -249,7 +249,7 @@ class ArrayOfArraysView | |
|
|
||
| /** | ||
| * @brief Move assignment operator.. | ||
| * @param src the SparsityPatternView to be moved from. | ||
| * @param src the ArrayOfArraysView to be moved from. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice |
||
| * @return *this. | ||
| */ | ||
| LVARRAY_HOST_DEVICE | ||
|
|
@@ -1087,4 +1087,23 @@ class ArrayOfArraysView | |
| } | ||
| }; | ||
|
|
||
| /** | ||
| * @brief True if the template type is an ArrayOfArraysView. | ||
| */ | ||
| template< class > | ||
| constexpr bool isArrayOfArraysView = false; | ||
|
|
||
| /** | ||
| * @tparam T The type contained in the ArrayOfArraysView. | ||
| * @tparam INDEX_TYPE The integral type used as an index. | ||
| * @tparam CONST_SIZES True iff the size of each array is constant. | ||
| * @tparam BUFFER_TYPE The type used to manager the underlying allocation. | ||
| * @brief Specialization of isArrayOfArraysView for the ArrayOfArraysView class. | ||
| */ | ||
| template< typename T, | ||
| typename INDEX_TYPE, | ||
| bool CONST_SIZES, | ||
| template< typename > class BUFFER_TYPE > | ||
| constexpr bool isArrayOfArraysView< ArrayOfArraysView< T, INDEX_TYPE, CONST_SIZES, BUFFER_TYPE > > = true; | ||
|
|
||
| } /* namespace LvArray */ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -340,7 +340,7 @@ class ChaiBuffer | |
|
|
||
| if( size > 0 ) | ||
| { | ||
| LVARRAY_ERROR_IF_NE_MSG( space, MemorySpace::host, "Calling reallocate with a non-zero current size is not yet supporeted for the GPU." ); | ||
| LVARRAY_ERROR_IF_NE_MSG( space, MemorySpace::host, "Calling reallocate with a non-zero current size is not yet supported for the GPU." ); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice |
||
| std::ptrdiff_t const overlapAmount = std::min( newCapacity, size ); | ||
| arrayManipulation::uninitializedMove( newPointer, overlapAmount, m_pointer ); | ||
| arrayManipulation::destroy( m_pointer, size ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unsure if this should go here or in GEOS itself.