Fatimah Almousa-Selection Project#8
Open
FatimahAlMousa wants to merge 2 commits intoGDSC-IAU:masterfrom
Open
Conversation
RyamAlmalki
reviewed
Feb 2, 2024
Contributor
RyamAlmalki
left a comment
There was a problem hiding this comment.
Overall, great job Fatimah! I'm so proud of you for successfully completing this project.
| @@ -1,5 +1,183 @@ | |||
| import 'core/note_app.dart'; | |||
| import 'dart:io'; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
It's considered a best practice to spread your classes across different files. Currently, you have all your code in one file, which can become challenging to read and manage as your codebase grows.
| //Creates a new note and adds it to the list of notes. | ||
| void createNote(){ | ||
| String title,content; | ||
| print("Enter the note title: "); |
Contributor
There was a problem hiding this comment.
It would have enhanced user-friendliness if you had incorporated a check to verify whether a title has already been used before proceeding with the creation of a new note.
| } | ||
|
|
||
| //Edit the title and content of note. | ||
| void EditNote(){ |
Contributor
There was a problem hiding this comment.
Ensure that you follow the Dart conventions by using lowerCamelCase when naming your functions.
editNote() start with small letter
| void createNote(){ | ||
| String title,content; | ||
| print("Enter the note title: "); | ||
| title=stdin.readLineSync() ?? "None"; |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

changes are:
1-add display in menu
2-solve some mistakes in delete method
3-add simple edit in main
screenshot:




















