Skip to content

Fatimah Almousa-Selection Project#8

Open
FatimahAlMousa wants to merge 2 commits intoGDSC-IAU:masterfrom
FatimahAlMousa:master
Open

Fatimah Almousa-Selection Project#8
FatimahAlMousa wants to merge 2 commits intoGDSC-IAU:masterfrom
FatimahAlMousa:master

Conversation

@FatimahAlMousa
Copy link

changes are:
1-add display in menu
2-solve some mistakes in delete method
3-add simple edit in main

screenshot:
Screenshot 2024-01-31 141957
Screenshot 2024-01-31 142042
Screenshot 2024-01-31 142128
Screenshot 2024-01-31 142204
Screenshot 2024-01-31 142248
Screenshot 2024-01-31 142323
Screenshot 2024-01-31 142404
Screenshot 2024-01-31 142432
Screenshot 2024-01-31 142544
Screenshot 2024-01-31 142616
Screenshot 2024-01-31 142641
Screenshot 2024-01-31 142721
Screenshot 2024-01-31 142757
Screenshot 2024-01-31 142825
Screenshot 2024-01-31 142852
Screenshot 2024-01-31 142919
Screenshot 2024-01-31 142956
Screenshot 2024-01-31 143030
Screenshot 2024-01-31 143101
Screenshot 2024-01-31 143131
Screenshot 2024-01-31 143204

Copy link
Contributor

@RyamAlmalki RyamAlmalki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great job Fatimah! I'm so proud of you for successfully completing this project.

@@ -1,5 +1,183 @@
import 'core/note_app.dart';
import 'dart:io';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's considered a best practice to spread your classes across different files. Currently, you have all your code in one file, which can become challenging to read and manage as your codebase grows.

//Creates a new note and adds it to the list of notes.
void createNote(){
String title,content;
print("Enter the note title: ");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have enhanced user-friendliness if you had incorporated a check to verify whether a title has already been used before proceeding with the creation of a new note.

}

//Edit the title and content of note.
void EditNote(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that you follow the Dart conventions by using lowerCamelCase when naming your functions.

editNote() start with small letter

void createNote(){
String title,content;
print("Enter the note title: ");
title=stdin.readLineSync() ?? "None";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense for a user to create a note without providing a name.
Screen Shot 1445-07-21 at 4 26 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants