taima aldossary - selection project by taima-aldossary · Pull Request #6 · GDSC-IAU/Selection-Project

taima-aldossary · 2024-01-30T17:09:31Z

I have implemented a user-friendly menu offering various options such as adding, editing, deleting, searching, and viewing notes. Also, there is a method for each option in the menu. The search method is employed within both the edit and delete methods to enhance code reusability.

RyamAlmalki

Overall, good job! Really proud of you. I can see the work and effort you have put in, and it's amazing. Don't take this as discouragement; there is always room for improvement. Take this as a challenge for next time to get better and better.

RyamAlmalki · 2024-02-02T11:11:25Z

src/core/note_app.dart

+    print('Note added successfully!');
+  }
+
+  void searchNote() {


This error has occurred from this given function.

First, let's take a look at how this error was produced.

The user decides to create 3 notes.

The user decides to delete the last note.

3.Now The user decides to delete the first note, but they didn't write the note name correct.

An error has occurred, as you can observe.

Now, why did this error occur?

The user decides to create 3 notes, and each note is assigned an index.

Afterward, the user decides to delete the last note.

3.Now The user decides to delete the first note, but they didn't write the note name correct.

Now, how to solve this issue?

RyamAlmalki · 2024-02-02T11:24:41Z

src/core/note_app.dart

  }
-}
+
+  void addNote() {


Add a condition in your add note to check that the name has not been used before, to avoid conflicts when deleting a specific note.

RyamAlmalki · 2024-02-02T11:38:19Z

src/core/note_app.dart

+    }
+  }
+
+  void editNote() {


Analyzing Logical Errors

Creating 2 Notes

Two notes were created with the following screenshot:

Searching for a Note

After creating the notes, a search for a specific note was initiated using this screenshot:

Editing a Note with a Wrong Name

A logical error occurred while editing a note. Accidentally, the wrong name was entered, leading to unexpected behavior:

Noteworthy: The system prompted for a title even with the wrong name.

Unintended Note Edit

Upon reviewing my notes, a startling observation was made— a note was edited without specific user request:

All of these issues can be attributed to the use of index=-1. This global value requires careful handling in each function to avoid unintended consequences. It serves as a reminder to exercise caution when utilizing global variables across functions in your code.

solution is to set it back

RyamAlmalki · 2024-02-02T11:47:10Z

src/core/note_app.dart

+
+import '../models/note_model.dart';
+
 class NoteApp {


It would have been a better option to separate this class more for readability. One that handles the menu operations and another that handles note app functionality, such as add/delete operations

RyamAlmalki · 2024-02-02T11:58:49Z

src/core/note_app.dart

+        print('Enter the note title: ');
+        title = stdin.readLineSync()!;
+
+        if (title == null || title.trim().isEmpty) {


!: The null assertion operator. It is used to assert that the value to its left is non-null. It essentially tells the Dart analyzer that you are confident the value won't be null at runtime.

so having title == null is not needed since it will not be null