Fatimah Al-Abdullah - Selection Project#5
Fatimah Al-Abdullah - Selection Project#5Lekserforsker wants to merge 1 commit intoGDSC-IAU:masterfrom
Conversation
Lekserforsker
commented
Jan 29, 2024
Lekserforsker
commented
- A description of the changes made:
- I added a change in the note_app.dart file.
- I added a change in the utils.dart file.
- I added a change in the note_model file.
- I added a change in the main.dart file.
- I added a file containing all the programming code and named it (ProjectAllHere.dart).
- A screenshot of the app running in the terminal:
Lekserforsker
changed the title
RyamAlmalki
left a comment
RyamAlmalki
left a comment
There was a problem hiding this comment.
Overall good job Fatimah!!!
| } | ||
|
|
||
| // Creates a new Note instance with the given content. | ||
| void createNote() { |
There was a problem hiding this comment.
It would have been more user-friendly if you gave the user the option to add a title to the note.
| @@ -0,0 +1,229 @@ | |||
| import 'dart:io'; | |||
There was a problem hiding this comment.
It seems that you have combined everything into one page, which is not the best approach to follow in programming. It's best practice to break down classes into different pages for readability.
| } | ||
|
|
||
| // Deletes the Note at the given index. | ||
| void deleteNote(int index) { |
There was a problem hiding this comment.
It would have been better if you made the note have a title to serve as its own unique ID. This way, the user can easily remember what they want to delete.
For example, if I have this set of notes in my list
and then I decided to remove one note.
You can now notice that when I view my note list, the ID has been shifted. As a user, I only remember that my note 'I don't like math' is at index 2, but when I view it, it will be 1. So, this has a user-friendly issue when I try to delete.
2 participants
