aljwhara aldossary - selection-project #11
Open
aljwhara0 wants to merge 1 commit intoGDSC-IAU:masterfrom
Open
Conversation
RyamAlmalki
reviewed
Feb 2, 2024
Contributor
RyamAlmalki
left a comment
RyamAlmalki
left a comment
There was a problem hiding this comment.
Good job! 👏 Very proud of you! Can't wait to see more of your work.
|
|
||
| void createNote() { | ||
| stdout.write('Enter note title: '); | ||
| final title = stdin.readLineSync() ?? ''; |
Contributor
There was a problem hiding this comment.
You should check that the user hasn't entered a null title, as you don't want the title to be without a name.
Radwan-Albahrani
left a comment
Radwan-Albahrani
left a comment
There was a problem hiding this comment.
Great work. Lacks a bit in creativity though, feels a little plain. Here are some suggestions to help improve functionality.
Comment on lines
+42
to
+43
| stdout.write('Enter note content: '); | ||
| final content = stdin.readLineSync() ?? ''; |
Comment on lines
+73
to
+76
| stdout.write('Enter new note title: '); | ||
| final newTitle = stdin.readLineSync() ?? ''; | ||
| stdout.write('Enter new note content: '); | ||
| final newContent = stdin.readLineSync() ?? ''; |
There was a problem hiding this comment.
As well as here
Suggested change
| stdout.write('Enter new note title: '); | |
| final newTitle = stdin.readLineSync() ?? ''; | |
| stdout.write('Enter new note content: '); | |
| final newContent = stdin.readLineSync() ?? ''; | |
| stdout.write('Enter new note title: '); | |
| final newTitle = stdin.readLineSync() ?? ''; | |
| if(newTitle.isEmpty) | |
| { | |
| print("Cannot have empty title"); | |
| } | |
| stdout.write('Enter new note content: '); | |
| final newContent = stdin.readLineSync() ?? ''; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.